iroha icon indicating copy to clipboard operation
iroha copied to clipboard

Validate and execute queries through executor

Open mversic opened this issue 1 year ago • 3 comments

Let's discuss here how queries should go through the process of validation and execution through executor. Currently, they only undergo validation. Does it even make sense to have permissions for queries since anyone can just hook onto listen_for_blocks anyway?

Superseeds discussion in #3658

mversic avatar Jul 19 '24 11:07 mversic

I think query permissions might be useful in permissioned setting where nodes can restrict users from accessing listen_for_blocks, afaik FIB has such query permissions, @Mingela is that correct?

Erigara avatar Jul 25 '24 06:07 Erigara

Execute queries inside executor might have performance impact due 2 rounds of additional (de)serialization.

Erigara avatar Jul 25 '24 06:07 Erigara

We don't have many permissions yet, but that was an idea. I believe there should be a way to expand the default query execution with an arbitrary logic (like custom ISI), e.g. charge a fee for a specific query. Not sure if that could be implemented in an alternative way (e.g. prohibit all queries allowing just custom ISI producing custom events for return values + consumer subscribed to such events).

Mingela avatar Aug 06 '24 06:08 Mingela