iroha icon indicating copy to clipboard operation
iroha copied to clipboard

Implement `Instruction` for `*Box` wrappers

Open nxsaken opened this issue 1 year ago • 2 comments

Currently, only InstructionBox implements Instruction out of all ISI wrappers. I expected RegisterBox, MintBox and the rest of the wrappers to be usable with iroha.submit_*() directly, but they are not. I think it would be more ergonomic if they were.

nxsaken avatar Jun 06 '24 11:06 nxsaken

related to #4703

mversic avatar Jun 14 '24 09:06 mversic

Additionally, change instances of impl IntoIterator<Item = impl Instruction> function parameters to impl IntoIterator<Item = I>, I: Instruction, which is more flexible due to the turbofish syntax being available. This would allow wrapping multiple instructions into *Boxes without binding them to a separate variable.

nxsaken avatar Jul 01 '24 14:07 nxsaken