iroha
iroha copied to clipboard
fix: Report if a request to check peer status in test_network fails
Description
Warn if a peer status request is failed. Helped me debug my misconfigured proxy failing tests when ran in IDE...
This also refactors a function a bit, because IMO it was a bit hard to read with the fold and map_or
Linked issue
Closes #4542
Benefits
+ Easier debugging if something went wrong with requests
- Can introduce log noise, but shouldn't happen if the actual connection to the node is OK
Hey there and thank you for opening this pull request! 👋🏼
We require pull request titles to follow the Conventional Commits specification, and it looks like your proposed title needs to be adjusted.
Details:
No release type found in pull request title "[fix] #4542: Report if a request to check peer status in test_network fails". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/
Available types:
- feat: A new feature
- fix: A bug fix
- docs: Documentation only changes
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
- refactor: A code change that neither fixes a bug nor adds a feature
- perf: A code change that improves performance
- test: Adding missing tests or correcting existing tests
- build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
- ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
- chore: Other changes that don't modify src or test files
- revert: Reverts a previous commit