iroha icon indicating copy to clipboard operation
iroha copied to clipboard

[suggestion] Adopt multihash format for private keys

Open 0x009922 opened this issue 1 year ago • 2 comments

In configurations, we use the following format for public/private keys:

public_key = "ed012014A2900349A8CB6250D8CE5399D1964766B559A37F48E8C98C1EA83F365D8A72"
private_key = { algorithm = "ed25519", payload = "67AAB998A3951A071324B815BAF425309D6AF8D2D2636A3FC2BEA01C322BC23B14A2900349A8CB6250D8CE5399D1964766B559A37F48E8C98C1EA83F365D8A72" }

While multihash format is used for public_key, why can't we use it for the private one too?

It would make config more consistent and less confusing, and will also remove necessity to set private key in the environment through 2 split variables PRIVATE_KEY_ALGORITHM and PRIVATE_KEY_PAYLOAD.

0x009922 avatar Apr 10 '24 04:04 0x009922

Sounds good to me, what are downsides?

Erigara avatar Apr 10 '24 07:04 Erigara

Same position here. Sounds good and doesn't seem to have any downsides on the first glance.

DCNick3 avatar Apr 11 '24 06:04 DCNick3