iroha icon indicating copy to clipboard operation
iroha copied to clipboard

[feature] #4093, #4110: Add public key mint and burn commands to `iroha_client_cli`

Open nxsaken opened this issue 1 year ago • 3 comments

Description

  • Add a client CLI command for adding a new signatory to an account (minting a public key for an account).
  • Add a client CLI command for burning a public key from an account.

Linked issue

Closes #4093 and #4110.

Checklist

  • [x] I've read CONTRIBUTING.md
  • [x] I've used the standard signed-off commit format (or will squash just before merging)
  • [ ] All applicable CI checks pass (or I promised to make them pass later)
  • [ ] (optional) I've written unit tests for the code changes
  • [ ] I replied to all comments after code review, marking all implemented changes with thumbs up

nxsaken avatar Apr 04 '24 07:04 nxsaken

Is there a reason why minting a key for account is in the account subcommand, but burning is in an entirely new one?

DCNick3 avatar Apr 04 '24 07:04 DCNick3

I simply went with the formats described in the respective issues. They probably should be under the same subcommand, but I wanted to get feedback first.

nxsaken avatar Apr 04 '24 07:04 nxsaken

Pull Request Test Coverage Report for Build 8550778779

Details

  • 0 of 24 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5346 unchanged lines in 95 files lost coverage.
  • Overall coverage increased (+0.9%) to 57.644%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client_cli/src/main.rs 0 24 0.0%
<!-- Total: 0 24
Files with Coverage Reduction New Missed Lines %
primitives/src/conststr.rs 1 91.14%
crypto/src/hash.rs 1 73.78%
ffi/derive/src/convert.rs 1 84.45%
primitives/src/lib.rs 1 0.0%
core/src/sumeragi/network_topology.rs 1 98.78%
primitives/src/must_use.rs 2 74.29%
crypto/src/signature/bls/mod.rs 2 0.0%
config/src/snapshot.rs 3 78.57%
data_model/derive/src/has_origin.rs 3 95.16%
config/src/kura.rs 3 80.0%
<!-- Total: 5346
Totals Coverage Status
Change from base Build 7884695009: 0.9%
Covered Lines: 23491
Relevant Lines: 40752

💛 - Coveralls

coveralls avatar Apr 04 '24 15:04 coveralls