iroha icon indicating copy to clipboard operation
iroha copied to clipboard

[refactor] #4039: Enhance ClientCli Wait Mechanism for Transaction Completion in pytests and Remove Fixed Sleeps

Open AlexStroke opened this issue 1 year ago • 2 comments

Description

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • [ ] I've read CONTRIBUTING.md
  • [ ] I've used the standard signed-off commit format (or will squash just before merging)
  • [ ] All applicable CI checks pass (or I promised to make them pass later)
  • [ ] (optional) I've written unit tests for the code changes
  • [ ] I replied to all comments after code review, marking all implemented changes with thumbs up

AlexStroke avatar Mar 04 '24 18:03 AlexStroke

Pull Request Test Coverage Report for Build 8555785955

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5346 unchanged lines in 95 files lost coverage.
  • Overall coverage increased (+0.9%) to 57.676%

Files with Coverage Reduction New Missed Lines %
primitives/src/conststr.rs 1 91.14%
crypto/src/hash.rs 1 73.78%
ffi/derive/src/convert.rs 1 84.45%
primitives/src/lib.rs 1 0.0%
core/src/sumeragi/network_topology.rs 1 98.78%
primitives/src/must_use.rs 2 74.29%
crypto/src/signature/bls/mod.rs 2 0.0%
config/src/snapshot.rs 3 78.57%
data_model/derive/src/has_origin.rs 3 95.16%
config/src/kura.rs 3 80.0%
<!-- Total: 5346
Totals Coverage Status
Change from base Build 7884695009: 0.9%
Covered Lines: 23491
Relevant Lines: 40729

💛 - Coveralls

coveralls avatar Mar 11 '24 08:03 coveralls

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification, and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[refactor] #4039: Enhance ClientCli Wait Mechanism for Transaction Completion in pytests and Remove Fixed Sleeps ". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

github-actions[bot] avatar May 03 '24 16:05 github-actions[bot]

Closed this draft because we decided to make better solution not in the test framework. https://github.com/hyperledger/iroha/issues/4753

AlexStroke avatar Jun 20 '24 18:06 AlexStroke