iroha icon indicating copy to clipboard operation
iroha copied to clipboard

[suggestion] Consider using struct variants internally

Open appetrosyan opened this issue 3 years ago • 1 comments

Feature request

We might consider expanding the scope of IntoSchema to parse Struct-like variants, instead of referring the users to a non-existent style guide.

Motivation

In most cases a structure-like variant can make the code much more concise, and enforce a few invariants in the process. As we have significant duplication of responsibilities, it might make sense to add an extra processing step that auto-generates the information as needed, rather than defaulting to an error message.

Who can help?

No response

appetrosyan avatar Jul 14 '22 07:07 appetrosyan

regarding the data_model, this issue might be in conflict with #2491 . However, this enhancement will most likely be used only in data_model. I've added it as a blocking dependency so we can evaluate after #2491 is implemented

mversic avatar Jul 27 '22 11:07 mversic

Indeed, this is likely no longer required. Closing as not planned.

appetrosyan avatar Oct 30 '22 14:10 appetrosyan