iroha
iroha copied to clipboard
[ci] #2309: Re-enable doc tests in CI
Description of the Change
Features
- Enable doc tests in
tests_with_coveragejob - Enable
--no-fail-fastintests_with_coveragejob - Add tests with
--no-default-featuresmainly forno_std - Consolidate
Dockerfile.buildandDockerfile
Refactors
- Consolidate
iroha2-stable*.ymlandiroha2-lts*.yml - Rename image
iroha2-citoiroha2-base
Fixes
- Fix doc tests
Issue
- Closes #2309
- Opens #2604
Benefits
- CI will test the examples in the documentation, which have not been tested since #2223
- CI will run all tests regardless of failure
- CI will test the codebase with no default features, which has not been tested before
- No need for separate build of prior images
Possible Drawbacks
- Takes more CI time. Allows doc tests to use nightly features
- None
- Consumes 2 more runners
- None
Codecov Report
Merging #2427 (74eb719) into iroha2-dev (a16d9c3) will decrease coverage by
1.97%. The diff coverage is69.67%.
@@ Coverage Diff @@
## iroha2-dev #2427 +/- ##
==============================================
- Coverage 67.61% 65.63% -1.98%
==============================================
Files 140 163 +23
Lines 26173 28713 +2540
==============================================
+ Hits 17696 18846 +1150
- Misses 8477 9867 +1390
| Impacted Files | Coverage Δ | |
|---|---|---|
| actor/src/actor_id.rs | 90.00% <ø> (ø) |
|
| actor/src/deadlock.rs | 100.00% <ø> (ø) |
|
| cli/derive/src/lib.rs | 92.30% <ø> (+17.58%) |
:arrow_up: |
| cli/src/event.rs | 41.86% <ø> (ø) |
|
| cli/src/main.rs | 1.35% <ø> (ø) |
|
| cli/src/stream.rs | 81.39% <ø> (ø) |
|
| cli/src/torii/mod.rs | 28.88% <0.00%> (ø) |
|
| client/src/http.rs | 47.82% <ø> (ø) |
|
| client/src/http_default.rs | 41.59% <ø> (-18.59%) |
:arrow_down: |
| client_cli/src/main.rs | 0.27% <0.00%> (+0.01%) |
:arrow_up: |
| ... and 211 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Converted to draft because I'd like to wait for #2433 merge. I'd welcome reviews, but further changes would be made during resolving the conflicts
This PR needs to be squashed.