Ubuntu 22.04
Modified all tests to no longer require on indy-sdk. Started from where Adam left off. Please correct any changes where I am using wrong inputs/outputs
@rhofirAtos, Your latest commit is missing DCO sign-off.
lol, I see you noticed. Thanks
@WadeBarnes I've addressed your comment regarding duplication in the request parsing/conversion by creating a helper function called convert_indy_vdr_request_to_plenum(). I'll include this in my next push.
Tests are still having issues with ioflo. It should be replaced as a test dependency so the tests can proceed and we get a better idea of where we're at with this PR.
DCO sign-off was not included in the most recent commit. @rhofirAtos, please amend your latest commit with DCO sign-off.
@R3CK0, Whatever's happened between this point https://github.com/hyperledger/indy-plenum/actions/runs/14197083841 and now is a step backwards. The tests where running and one slice was passing. In the current state the tests aren't able to even run.
That said, affected tests are running and passing locally.
I'm able to recrate the error locally by running the tests like the workflows do:
RUSTPYTHONASYNCIODEBUG=0 python3 runner.py --pytest "python3 -m pytest -l -vv" --dir "plenum" --output "test-result-plenum-1.txt" --test-only-slice "1/8"
Logs get output to test_list.txt
==================================== ERRORS ====================================
___ ERROR collecting plenum/test/plugin/demo_plugin/test_plugin_removing.py ____
ImportError while importing test module '/workspaces/indy-plenum/plenum/test/plugin/demo_plugin/test_plugin_removing.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
plenum/test/plugin/demo_plugin/test_plugin_removing.py:5: in <module>
from plenum.test.freeze_ledgers.helper import sdk_send_freeze_ledgers
E ImportError: cannot import name 'sdk_send_freeze_ledgers' from 'plenum.test.freeze_ledgers.helper' (/workspaces/indy-plenum/plenum/test/freeze_ledgers/helper.py)
Plenum slice tests are running again.
I'll have a look at the conflicts shortly.
Removed the commit containing the error logs and the error identification script.
Removed the commit containing the error logs and the error identification script.
In doing so it appears you've also removed several commits I had made to the PR.
I'll put them back
I'm sorry, didn't realise, nothing else came up in my git logs after pulling, I assumed it was safe to push back one commit, or at least what I thought was one commit
All fixed.