indy-plenum icon indicating copy to clipboard operation
indy-plenum copied to clipboard

Ubuntu 22.04

Open R3CK0 opened this issue 10 months ago • 14 comments

Modified all tests to no longer require on indy-sdk. Started from where Adam left off. Please correct any changes where I am using wrong inputs/outputs

R3CK0 avatar Feb 25 '25 20:02 R3CK0

@rhofirAtos, Your latest commit is missing DCO sign-off.

lol, I see you noticed. Thanks

WadeBarnes avatar Mar 04 '25 15:03 WadeBarnes

@WadeBarnes I've addressed your comment regarding duplication in the request parsing/conversion by creating a helper function called convert_indy_vdr_request_to_plenum(). I'll include this in my next push.

safio avatar Mar 07 '25 18:03 safio

Tests are still having issues with ioflo. It should be replaced as a test dependency so the tests can proceed and we get a better idea of where we're at with this PR.

WadeBarnes avatar Mar 10 '25 13:03 WadeBarnes

DCO sign-off was not included in the most recent commit. @rhofirAtos, please amend your latest commit with DCO sign-off.

WadeBarnes avatar Mar 12 '25 14:03 WadeBarnes

@R3CK0, Whatever's happened between this point https://github.com/hyperledger/indy-plenum/actions/runs/14197083841 and now is a step backwards. The tests where running and one slice was passing. In the current state the tests aren't able to even run.

WadeBarnes avatar Apr 08 '25 13:04 WadeBarnes

That said, affected tests are running and passing locally.

WadeBarnes avatar Apr 08 '25 13:04 WadeBarnes

I'm able to recrate the error locally by running the tests like the workflows do:

RUSTPYTHONASYNCIODEBUG=0 python3 runner.py --pytest "python3 -m pytest -l -vv" --dir "plenum" --output "test-result-plenum-1.txt" --test-only-slice "1/8"

Logs get output to test_list.txt

==================================== ERRORS ====================================
___ ERROR collecting plenum/test/plugin/demo_plugin/test_plugin_removing.py ____
ImportError while importing test module '/workspaces/indy-plenum/plenum/test/plugin/demo_plugin/test_plugin_removing.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
plenum/test/plugin/demo_plugin/test_plugin_removing.py:5: in <module>
    from plenum.test.freeze_ledgers.helper import sdk_send_freeze_ledgers
E   ImportError: cannot import name 'sdk_send_freeze_ledgers' from 'plenum.test.freeze_ledgers.helper' (/workspaces/indy-plenum/plenum/test/freeze_ledgers/helper.py)

WadeBarnes avatar Apr 08 '25 14:04 WadeBarnes

Plenum slice tests are running again.

WadeBarnes avatar Apr 08 '25 15:04 WadeBarnes

I'll have a look at the conflicts shortly.

WadeBarnes avatar Apr 09 '25 15:04 WadeBarnes

Removed the commit containing the error logs and the error identification script.

R3CK0 avatar Apr 09 '25 19:04 R3CK0

Removed the commit containing the error logs and the error identification script.

In doing so it appears you've also removed several commits I had made to the PR.

image

WadeBarnes avatar Apr 09 '25 19:04 WadeBarnes

I'll put them back

WadeBarnes avatar Apr 09 '25 19:04 WadeBarnes

I'm sorry, didn't realise, nothing else came up in my git logs after pulling, I assumed it was safe to push back one commit, or at least what I thought was one commit

R3CK0 avatar Apr 09 '25 19:04 R3CK0

All fixed.

WadeBarnes avatar Apr 09 '25 20:04 WadeBarnes