indy-node icon indicating copy to clipboard operation
indy-node copied to clipboard

Add SET_FEES, GET_FEE and GET_FEES txns

Open Toktar opened this issue 4 years ago • 6 comments

Toktar avatar Feb 16 '21 09:02 Toktar

@Toktar, Can you remind me which HIPE is associated to this work?

WadeBarnes avatar Mar 24 '21 14:03 WadeBarnes

a HIPE describing fee transactions for Indy is here: https://github.com/hyperledger/indy-hipe/tree/master/text/0161-generic-token, but it is not clear to me that the HIPE was used as the specification for this PR. Do the GET_FEES and SET_FEES transaction described in the HIPE match the ones implemented here? The HIPE also describes COLLECT_FEES and UNCOLLECTED_FEES that are not implemented here, unless one of them maps to GET_FEE. Where is GET_FEE described?

brentzundel avatar Mar 24 '21 16:03 brentzundel

Here is the HIPE: https://github.com/hyperledger/indy-hipe/tree/master/text/0163-default-fee-handler

askolesov avatar Mar 25 '21 08:03 askolesov

@Toktar Should we merge it in case we don't remove tokens? I think no. Please correct me if I'm wrong.

askolesov avatar Mar 25 '21 08:03 askolesov

Here is the HIPE: https://github.com/hyperledger/indy-hipe/tree/master/text/0163-default-fee-handler

This HIPE does not describe GET_FEES nor GET_FEE, can you point me to documentation of those transactions?

brentzundel avatar Mar 26 '21 22:03 brentzundel

@Toktar Could you provide a brief update on this PR? With recent branch changes and the current development process on Indy Node/Plenum, we are wondering if these changes are still viable. If so, please close this PR and retarget it to main.

We will discuss and determine which PRs should be merged or closed at the next Indy Contributors Working Group meeting on May 9, 2023.

cjhowland avatar Apr 25 '23 23:04 cjhowland