firefly-fabconnect icon indicating copy to clipboard operation
firefly-fabconnect copied to clipboard

Published 20 hours ago • verified publisher icon hyperledger

Inconsistent transactionId field name on receipts/events

Open peterbroadhurst opened this issue 3 years ago • 0 comments

We have a mix of:

  • transactionHash
  • transactionID
  • transactionId

Receipts seem to be the place that should change: https://github.com/hyperledger/firefly-fabconnect/blob/9b005b6664e65e3e0645cd5d5c03c6c9c9354a0e/internal/messages/messages.go#L140-L155

To match events which use transactionId: https://github.com/hyperledger/firefly-fabconnect/blob/afde10c5c4139db48f2695d3845ddc9b15a45817/internal/events/api/event.go#L64-L73

peterbroadhurst avatar Jan 25 '22 17:01 peterbroadhurst