firefly-fabconnect icon indicating copy to clipboard operation
firefly-fabconnect copied to clipboard

Parameter handling is inconsistent

Open Tillaert opened this issue 1 year ago • 2 comments

Currently, parameters that are objects are not encoded as strings, however, arrays are.

Object parameter: https://github.com/hyperledger/firefly-fabconnect/blob/main/internal/rest/utils/params_test.go#L91 Array parameter: https://github.com/hyperledger/firefly-fabconnect/blob/main/internal/rest/utils/params_test.go#L306

This is not consistent, and begs the question how to pass objects with nested arrays and arrays of objects.

Tests are missing for objectArray.

Firefly is sending objects encoded as strings, and this results in errors, see:

https://github.com/hyperledger/firefly/issues/1307

Tillaert avatar Jul 08 '23 10:07 Tillaert

@DerekJarvis You have more insight into this?

Tillaert avatar Jul 08 '23 10:07 Tillaert

@DerekJarvis You have more insight into this?

Sorry - haven't worked with Firefly for some time. I did a PR that tried to improve some type handling, but overall it doesn't seem like a current focus of Firefly to handle the complex data types that Hyperledger Fabric supports.

DerekJarvis avatar Jul 13 '23 07:07 DerekJarvis