spec.yaml or README.md out of date

[kmilodenisglez]

Hi @nguyer, @jimthematrix

The "payloadType" property of the "SubscriptionInfo" structure in internal/events/api/event.go accepts the data types "bytes", "string" or "stringifiedJSON/json".

or is the README.md the one that is not updated?

But in the spec.yaml only "json" and "string" are accepted.

[nguyer]

I think this is correct. In this case "bytes" are passed in as a string encded as hex or base64.

[kmilodenisglez]

I think this is correct. In this case "bytes" are passed in as a string encded as hex or base64.

so it is that the README.md should be updated, right?

Because an example in the readme uses the "stringifiedJSON" value for the "payloadType" property, at https://github.com/hyperledger/firefly-fabconnect#json-data-support-in-events

[nguyer]

Sorry I'm not understanding or seeing anything that is not correct here. "Stringified JSON" is just a string so it's still valid.

[kmilodenisglez]

Sorry I'm not understanding or seeing anything that is not correct here. "Stringified JSON" is just a string so it's still valid.

when I put the value "stringifiedJSON" to the property "payloadType", this is the response that the endpoint "http://localhost:3000/subscriptions" returns:

[kmilodenisglez]

It only lets me pass the values "string" or "json"

[nguyer]

Ah okay, I get it. Sorry I was slow to understand this one! I think the readme can be changed to just say "string" there instead.

[kmilodenisglez]

Ah okay, I get it. Sorry I was slow to understand this one! I think the readme can be changed to just say "string" there instead.

Exactly, sorry if I didn't explain well. My English is not very good

[kmilodenisglez]

pull-request: https://github.com/hyperledger/firefly-fabconnect/pull/104