firefly-cli icon indicating copy to clipboard operation
firefly-cli copied to clipboard

Published 20 hours ago • verified publisher icon hyperledger

Add GitHub Action to run Makefile

Open nguyer opened this issue 3 years ago • 3 comments

In order to make sure PRs are acceptable, we should be testing that the code compiles and passes all the linting rules added in https://github.com/hyperledger-labs/firefly-cli/issues/42

nguyer avatar Jun 15 '21 19:06 nguyer

With the addition of goreleaser in https://github.com/hyperledger-labs/firefly-cli/pull/76, do we still need this?

shorsher avatar Aug 05 '21 17:08 shorsher

I think we still need this. I'd like to have assurance that changes in a PR won't prevent make from running locally before things get merged.

nguyer avatar Aug 10 '21 13:08 nguyer

Hi, should this issue be closed? It seems like the change has been merged. https://github.com/hyperledger/firefly-cli/pull/98

yuriechan avatar Jul 05 '23 12:07 yuriechan