firefly-cli icon indicating copy to clipboard operation
firefly-cli copied to clipboard

All hex address values should be wrapped as HexAddress

Open awrichar opened this issue 2 years ago • 3 comments

Due to https://github.com/go-yaml/yaml/issues/847, we have a wrapper type for hex addresses that will explicitly quote them as strings: https://github.com/hyperledger/firefly-cli/blob/main/pkg/types/hex_address.go

This is used sparingly right now, but should be used for all hex addresses output by the CLI.

awrichar avatar Dec 13 '22 16:12 awrichar

Hi, Can I start working on it?

uday03meh avatar Dec 15 '22 21:12 uday03meh

@uday03meh it would be great if you're still thinking of working on this.

awrichar avatar Feb 03 '23 13:02 awrichar

is this issue still open , i can look into it

Philip-21 avatar Dec 13 '23 16:12 Philip-21