fabric icon indicating copy to clipboard operation
fabric copied to clipboard

Update docs for Ed25519 support

Open denyeart opened this issue 1 year ago • 1 comments

Update docs for Ed25519 support. Also clarify ECDSA and RSA support.

denyeart avatar Jun 27 '24 21:06 denyeart

@johannww @adecaro @ale-linux Please review

denyeart avatar Jun 27 '24 21:06 denyeart

@johannww Just to confirm, does your thumbs up mean you've reviewed and approve the doc updates? Or that you intend to review? Once you confirm I think we can merge...

denyeart avatar Jul 17 '24 15:07 denyeart

@denyeart I will review. I had the impression that it was already merged, that is why I forgot about it.

johannww avatar Jul 17 '24 15:07 johannww

It's good for me. I would say that there is no update for the cryptogen docs. However, I noticed that the cryptogen docs are very generic, and following this principle, there is no reason to highlight it. Besides, the algorithm support is already mentioned on the default config cmd/cryptogen/main.go line 131.

johannww avatar Jul 17 '24 20:07 johannww

It's good for me. I would say that there is no update for the cryptogen docs. However, I noticed that the cryptogen docs are very generic, and following this principle, there is no reason to highlight it. Besides, the algorithm support is already mentioned on the default config cmd/cryptogen/main.go line 131.

Yeah, It looks like for crytpogen there is no doc for the template beyond stating that you can do cryptogen showtemplate, and if you do so, the template states that you can specify "ecdsa" or "ed25519", so I think it is fine, I'll go ahead and merge.

denyeart avatar Jul 19 '24 20:07 denyeart