fabric icon indicating copy to clipboard operation
fabric copied to clipboard

Remove Idemixgen from Fabric produced binaries

Open Sayalikukkar opened this issue 1 year ago • 5 comments

Type of change

  • Documentation update

Description

Removed Idemixgen from the documentation to reflect its removal from the set of Fabric produced binaries. Also created the seperate PR for idemix repo.

Additional details

Related issues

Closes https://github.com/hyperledger/fabric/issues/3575

Sayalikukkar avatar May 03 '24 14:05 Sayalikukkar

Thank you for the update.

There is also a link to this document in a table of contents that needs to be removed at the same time - https://raw.githubusercontent.com/hyperledger/fabric/main/docs/source/ops_guide.rst

Also https://github.com/hyperledger/fabric/blob/main/docs/source/idemix.rst mentions that Fabric provides this tool. I think we'd want to update that wording from "Fabric provides two possible Idemix issuers" to "There are two possible Idemix issuers". And make "idemix tool" a hyperlink over to https://github.com/IBM/idemix.

Finally, I think we'd want this doc content to appear at https://github.com/IBM/idemix where the tool now resides, before removing it from Fabric docs, do you want to submit the PR to https://github.com/IBM/idemix as well to complete the move?

denyeart avatar May 04 '24 14:05 denyeart

@denyeart , Sure, I'm interested in helping with that. I can make the necessary updates to the Fabric documentation as you've described and also submit a pull request to the IBM idemix repository to ensure the content is properly moved.

Sayalikukkar avatar May 04 '24 14:05 Sayalikukkar

Thank you, looks good to me now. But let's wait for @ale-linux to merge https://github.com/IBM/idemix/pull/41 to ensure we have the doc somewhere.

denyeart avatar May 09 '24 13:05 denyeart

Thank you for your feedback and guidance!

Sayalikukkar avatar May 09 '24 14:05 Sayalikukkar

Sorry, there is now a conflict in the doc, I think in the ops_guide table of contents. Could you resolve the conflict by rebasing locally and then re-push?

Also, it would be nice to squash the 3 commits into a single commit, see guidance at https://hyperledger-fabric.readthedocs.io/en/latest/github/github.html#updating-a-pull-request.

denyeart avatar May 15 '24 12:05 denyeart

Perfect, thank you!

denyeart avatar May 15 '24 18:05 denyeart