hyperledger
DOC / Update create_channel_test_net.md
The commit exhanges TwoOrgsApplicationGenesis with ChannelUsingRaft because of commit eb16ca in the fabric-sample repository.
- documentation update
- I opened an issue in fabric-sample for it
Good catch, thank you!
I also see the same reference in docs/source/test_network.md and docs/source/create_channel/create_channel_config.md , do you want to update those in the same PR?
I changed the according entries. Please be aware that within the create_channel_test_net-article the rest of the description of the configtx.yaml file does not seem to be up to date anymore.
The Capabilities and Applications are not mentioned in the description. The entry Etcdraft is now two times included, because it moved from Orderer to the Profiles section and I am not certain if the description is still correct (even if the block is removed).
I changed the according entries. Please be aware that within the create_channel_test_net-article the rest of the description of the configtx.yaml file does not seem to be up to date anymore.
The Capabilities and Applications are not mentioned in the description. The entry Etcdraft is now two times included, because it moved from Orderer to the Profiles section and I am not certain if the description is still correct (even if the block is removed).
Ok, thanks, I'll take a look.
One more thing, you'll need to sign the second commit as well to get the DCO check to pass, see https://github.com/hyperledger/fabric/pull/4528/checks?check_run_id=18410805423.
Alternatively, you can squash the two commits into a single signed commit. See https://hyperledger-fabric.readthedocs.io/en/latest/github/github.html#updating-a-pull-request.
Hello. I found that there are also sections in comments in fabric-samples that need to be revised. So, I've created the following patch and submited it. https://github.com/hyperledger/fabric-samples/pull/1146
Ok, the doc changes have been made in https://github.com/hyperledger/fabric/pull/4781 and https://github.com/hyperledger/fabric/pull/4788, closing.