fabric-sdk-py icon indicating copy to clipboard operation
fabric-sdk-py copied to clipboard

Changed consensus type E2E_Test from solo to raft

Open RohanShrothrium opened this issue 5 years ago • 23 comments

Signed-off-by: rohanshrothrium [email protected] This PR introduces changes to the e2e_test and now uses raft consensu for ordering instead of solo ordering.

RohanShrothrium avatar Oct 07 '20 08:10 RohanShrothrium

Hmm...why a lot of secret keys are changing?

dexhunter avatar Oct 07 '20 14:10 dexhunter

Hmm...why a lot of secret keys are changing?

+1. No need to regenerate those credentials?

yeasy avatar Oct 08 '20 02:10 yeasy

Hmm...why a lot of secret keys are changing?

@yeasy and @dexhunter, I'll use the previously used certificates and update the PR.

RohanShrothrium avatar Oct 09 '20 05:10 RohanShrothrium

I have reverted back to the previous certs! Please review the same!

RohanShrothrium avatar Oct 09 '20 13:10 RohanShrothrium

@RohanShrothrium What are those certificates under the test/fixtures/e2e_raft/crypto-config/.svn/?

dexhunter avatar Oct 09 '20 14:10 dexhunter

@RohanShrothrium What are those certificates under the test/fixtures/e2e_raft/crypto-config/.svn/?

Ohh I downloaded the previous version of the crypto-config and channel-artifacts using svn so that was leftover. I'll remove it.

RohanShrothrium avatar Oct 09 '20 14:10 RohanShrothrium

/azp run

dexhunter avatar Oct 14 '20 12:10 dexhunter

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 14 '20 12:10 azure-pipelines[bot]

@RohanShrothrium The error message is

	status = StatusCode.UNAVAILABLE
	details = "failed to connect to all addresses"
	debug_error_string = "{"created":"@1602679823.669218145","description":"Failed to pick subchannel","file":"src/core/ext/filters/client_channel/client_channel.cc","file_line":4133,"referenced_errors":[{"created":"@1602679823.669214245","description":"failed to connect to all addresses","file":"src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc","file_line":397,"grpc_status":14}]}"

which is different from the timeout error. I found this answer indicating that gRPC fails to connect to all the address because no server is running on the address. I think you need to add some timeout before the invocation.

dexhunter avatar Oct 14 '20 19:10 dexhunter

@dexhunter The error is because many integration tests use the utils.py, so I'll have to make changes to the rest of the integration tests too. I'll update the PR by the earliest.

RohanShrothrium avatar Oct 15 '20 15:10 RohanShrothrium

@dexhunter the CI fails in the e2e_test but when I run it locally it's passing. I don't know why exactly this is happening.

RohanShrothrium avatar Oct 21 '20 07:10 RohanShrothrium

/azp run

yeasy avatar Oct 26 '20 21:10 yeasy

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 26 '20 21:10 azure-pipelines[bot]

@RohanShrothrium If this is applicable for both HLF v1.4 and v2.x, please add a new patchset to https://github.com/hyperledger/fabric-sdk-py/tree/release-1.0 too.

yeasy avatar Oct 27 '20 16:10 yeasy

@RohanShrothrium Could you rebase the code and try again?

dexhunter avatar Oct 30 '20 04:10 dexhunter

The current error message is

 info: "error applying config update to existing channel \'businesschannel\': error authorizing update: error validating ReadSet: proposed update requires that key [Group]  /Channel/Application be at version 0, but it is currently at version 1"

at channel_creation of e2e_test

dexhunter avatar Nov 06 '20 04:11 dexhunter

/azp run

dexhunter avatar Nov 06 '20 04:11 dexhunter

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 06 '20 04:11 azure-pipelines[bot]

@dexhunter and @yeasy can you help me fix the issue with the CI failing. I'm not sure why this is happening.

RohanShrothrium avatar Nov 08 '20 08:11 RohanShrothrium

@RohanShrothrium Can you rebase to the latest commit of the master branch?

dexhunter avatar Nov 09 '20 10:11 dexhunter

/azp run

dexhunter avatar Nov 09 '20 21:11 dexhunter

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 09 '20 21:11 azure-pipelines[bot]

@RohanShrothrium Can you check the error log? It seems to be a configuration problem.

dexhunter avatar Nov 10 '20 03:11 dexhunter