fabric-ca icon indicating copy to clipboard operation
fabric-ca copied to clipboard

escape special charecters that can be set through the command line ar…

Open RohanShrothrium opened this issue 2 years ago • 6 comments

…guments

Signed-off-by: Rohan Shrothrium [email protected]

Type of change

  • Bug fix

Description

When we initialise a fabric ca server with an admin and adminpw, if they have special characters the ca behaves not as expected. These special characters can be in anything that can be passed through the command line arguments. This PR is meant to escape these special characters in the yml file.

RohanShrothrium avatar May 15 '22 19:05 RohanShrothrium

/azp run

denyeart avatar May 21 '22 13:05 denyeart

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 21 '22 13:05 azure-pipelines[bot]

/azp run

denyeart avatar Jun 17 '22 15:06 denyeart

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 17 '22 15:06 azure-pipelines[bot]

Close and Re-open to trigger CI.

denyeart avatar Mar 21 '23 19:03 denyeart

This PR causes a legitimate test failure in cmd/fabric-ca-server/main_test.go unit test TestErrors.

denyeart avatar Aug 29 '23 17:08 denyeart