cello icon indicating copy to clipboard operation
cello copied to clipboard

Fix some UI wording and typeset

Open dodo920306 opened this issue 6 months ago • 1 comments

  1. Remove the suffix ": password" for the login form. Before:

    After:

  2. Since validation.email.required and validation.email.wrong-format mention email as "邮箱地址", change placeholder text in the login form also as "邮箱地址".

  3. Add space between "selected" and the number. Before:

    After:

dodo920306 avatar Jun 07 '25 10:06 dodo920306

Well, it seems like the dashboard has enzyme as a devDependency, which in turn depends on cheerio. Five days ago, cheerio released a new version 1.1.0, which upgrades its dependency on undici from ^6.19.5 to ^7.10.0. Starting from [email protected], the minimum required Node.js version has been bumped to >=20.18.1.

Shall we consider updating the Node.js version in the base image of the dashboard? Or we can add

  "resolutions": {
    "cheerio": "1.0.0"
  }

Or include yarn.lock in the project (I prefer this the most).

Do you want me to make this a seperate issue?

dodo920306 avatar Jun 14 '25 06:06 dodo920306

Well, it seems like the dashboard has enzyme as a devDependency, which in turn depends on cheerio. Five days ago, cheerio released a new version 1.1.0, which upgrades its dependency on undici from ^6.19.5 to ^7.10.0. Starting from [email protected], the minimum required Node.js version has been bumped to >=20.18.1.

Shall we consider updating the Node.js version in the base image of the dashboard? Or we can add

  "resolutions": {
    "cheerio": "1.0.0"
  }

Or include yarn.lock in the project (I prefer this the most).

Do you want me to make this a seperate issue?

I didn’t find any usage of Enzyme in the dashboard, so maybe we can just remove it? @dodo920306

YoungHypo avatar Jun 20 '25 23:06 YoungHypo

I didn’t find any usage of Enzyme in the dashboard, so maybe we can just remove it? @dodo920306

Well, I'm actually not sure. It's not my project in the first place anyway. I don't know how it get in here in our package.json.

I can build the dashboard locally with Enzyme removed from my package.json. That's the best I can do to test if it can be safely removed.

Besides, it just treats the symptom not the cause. Including some sort of lock files (e.g. yarn.lock) and introducing automatical dependency management tools (e.g. dependabot) are the true solutions.

dodo920306 avatar Jun 21 '25 00:06 dodo920306