Documentation of the Ethereum Connector does not appear to match the implementation

[davidkel]

I'm no expert here but looking at the code there appears to be at least 2 properties which are not covered in the network configuration and there could be more

• chainId
• privacy

[Ayush9026]

@davidkel sir I will solve this issue.

[duckling69]

Hi, @davidkel I went through the code you mentioned ethereum.js which I assume is this and also went through the Ethereum connector docs but I've some doubts. By covering those properties in the documentation. do you simply mean adding a description of those properties in the documentation or is there more to it?

[davidkel]

@duckling69 I've not looked into the implementation really (not my area), but noticed that there were properties in the implementation that were not documented. What is really needed is to ensure that the documentation matches the implementation so an understanding of the capabilities of the implementation are required and then the documentation to be adjusted accordingly

[duckling69]

I think I got the issue which is inconsistency between docs and implementation. Can you assign me the issue so I'll start working on it as it may take sometime and will also require some code reviews // @davidkel

[davidkel]

Closing as we have had to drop ethereum and besu support so subsequently we are dropping the benchmarks as well