cacti
cacti copied to clipboard
feat(fabric-connector): add getDiscoveryResults endpoint
- Add getDiscoveryResults endpoint and connector method for reading structure of specified ledger channel.
- Add baseline test to check the response from this endpoint.
- Modify baseline test suite to work with already running ledger.
- Fix small errors in comment in other parts of the code
Closes #3726
Pull Request Requirements
- [ ] Rebased onto
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why. - [ ] Have git sign off at the end of commit message to avoid being marked red. You can add
-sflag when usinggit commitcommand. You may refer to this link for more information. - [ ] Follow the Commit Linting specification. You may refer to this link for more information.
Character Limit
- [ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
- [ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).
A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.
@outSH LGTM (the yarn lint is failing though)
@hyperledger-cacti/cacti-maintainers Please review when you get the chance.