cacti icon indicating copy to clipboard operation
cacti copied to clipboard

ci(github): fix type exports in examples/cactus-common-example-server

Open ruzell22 opened this issue 1 year ago • 2 comments

Description

Relates to: #3140

Ignore pattern has been added in tools/custom-checks/get-all-tgz-path.ts in PR #3561 for packages that are having error when running the newly added check in custom-checks to validate exported types being correct so that the job will pass for now.

This ticket is created to fix examples/cactus-common-example-server/hyperledger-cactus-common-example-server-*.tgz and delete it in the ignore pattern right after. For more info about the custom-check log, refer to this github action link: https://github.com/hyperledger-cacti/cacti/actions/runs/11798447068/job/32864671597?pr=3561

and this discussion reply: https://github.com/hyperledger-cacti/cacti/pull/3561#pullrequestreview-2430386262

Related link that can help with regards to the error logs: https://www.npmjs.com/package/@arethetypeswrong/cli

Acceptance Criteria

  1. ci yarn-custom-checks should pass
  2. remove the ignore pattern for this specific package in tools/custom-checks/get-all-tgz-path.ts

ruzell22 avatar Nov 13 '24 15:11 ruzell22

On hold for now, similar to #3633 , LedgerEvent is being exported in public-api.ts but is not reflecting on .js file when building. More details about the tests made here: https://github.com/hyperledger-cacti/cacti/pull/3654#issuecomment-2505367464 https://github.com/hyperledger-cacti/cacti/pull/3654#issuecomment-2509561816

ruzell22 avatar Dec 03 '24 03:12 ruzell22

@ruzell22 Packages in examples/* are not part of public API and can be modified anytime

outSH avatar Dec 03 '24 10:12 outSH

We are refactoring the CI, as part of https://github.com/hyperledger-cacti/cacti/issues/4037.

RafaelAPB avatar Oct 18 '25 17:10 RafaelAPB