cacti
cacti copied to clipboard
feat(corda): dockerfile update to include cordapps
Commit to be reviewed
feat(corda): dockerfile update to include cordapps
Primary Changes
----------------
1. Created AIO to support the deployment of Cordapps in Corda 5
2. Created corda-v5-cordapp-deployment.test.ts to test the AIO
Fixes #3442 Pull Request Requirements
- [ ] Rebased onto
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why. - [ ] Have git sign off at the end of commit message to avoid being marked red. You can add
-sflag when usinggit commitcommand. You may refer to this link for more information. - [ ] Follow the Commit Linting specification. You may refer to this link for more information.
Character Limit
- [ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
- [ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).
A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.
Adding to the above points
- Resolved review comments regarding the new dockerfile. This will be fixed with the issue: #3503
- Blocking this PR until the flow status response to be completed
@jagpreetsinghsasan @adrianbatuto Let's re-open this PR once the pre-conditions are met, closing it for now. Also, one more thing: Please place some links here in the comments for the issue+PR of the mentioned dependencies (flow status PR)