cacti icon indicating copy to clipboard operation
cacti copied to clipboard

feat(connector-daml): aio image

Open raynatopedrajeta opened this issue 1 year ago • 2 comments

Commit to be reviewed


feat(connector-daml): aio image

Primary Changes
----------------
1. Create a docker image on daml-all-in-one folder that contains an initial creation of DAML smart contracts

Fixes #3284

Pull Request Requirements

  • [ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • [ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • [ ] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • [ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • [ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

raynatopedrajeta avatar Jul 15 '24 06:07 raynatopedrajeta

@raynatopedrajeta please fix the PR message and the commit message (similar to how you did earlier, in your previous PR)

TheJagpreet avatar Jul 15 '24 07:07 TheJagpreet

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Jul 19 '24 10:07 gitguardian[bot]

@jagpreetsinghsasan Are we good to go from your side?

petermetz avatar Aug 13 '24 01:08 petermetz

Yes @petermetz , good to merge from my end.

TheJagpreet avatar Aug 13 '24 01:08 TheJagpreet