cacti icon indicating copy to clipboard operation
cacti copied to clipboard

feat(actionlint): fix the errors produced by the ActionLint tool

Open ruzell22 opened this issue 1 year ago • 1 comments

Commit to be reviewed


feat(actionlint): fix the errors produced by the ActionLint tool

Primary Changes
---------------

1. Fix errors found by Actionlint on multiple yaml files

fixes: #2651

Pull Request Requirements

  • [x] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • [x] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • [x] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • [x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • [x] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

ruzell22 avatar May 03 '24 03:05 ruzell22

Addressed the errors found by Actionlint excluding on test-weaver and weaver-deploy yaml files. Will create a separate issue for that and add this issue ticket as related.

Update: The issue created for it is https://github.com/hyperledger/cacti/issues/3243

ruzell22 avatar May 03 '24 03:05 ruzell22

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar May 18 '24 20:05 gitguardian[bot]