cacti icon indicating copy to clipboard operation
cacti copied to clipboard

chore(github): shorten ci.yaml workflow and job names

Open zondervancalvez opened this issue 10 months ago • 1 comments

Commit to be reviewed


chore(github): shorten ci.yaml workflow and job names

Primary Changes
----------------
ce - cactus-example
cp - cactus-plugin
cpk - cactus-plugin-keychain
cpl - cactus-plugin-ledger
cplc - cactus-plugin-ledger-connector
plc - plugin-ledger-connector
cpp - cactus-plugin-persistence
ct - cactus-test
ctp - cactus-test-plugin

Fixes: hyperledger#2624

Pull Request Requirements

  • [x] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • [x] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • [x] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • [x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • [x] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

zondervancalvez avatar Apr 17 '24 08:04 zondervancalvez

Hi @zondervancalvez May be it'd good if you can add the short-full form mappings (whatever you have in description) as comment in the ci.yaml? Just for anyone new trying to contribute.

sandeepnRES avatar May 06 '24 12:05 sandeepnRES

@zondervancalvez Thank you for this! Please resolve the merge conflicts and then we should be good to go (I see that the comments with the mappings are already added as requested by @sandeepnRES so I'm assuming that is taken care of)

petermetz avatar May 16 '24 00:05 petermetz

@zondervancalvez Please resolve the merge conflicts that just arose!

Conflicts has been addressed

zondervancalvez avatar May 17 '24 06:05 zondervancalvez

@zondervancalvez OK, thank you. Next time please also hit the re-request review button otherwise it doesn't show up in my review queue.

petermetz avatar May 18 '24 23:05 petermetz