cacti icon indicating copy to clipboard operation
cacti copied to clipboard
verified publisher icon hyperledger

test(connector-polkadot): fix broken tests (all) due to ESM imports

Open petermetz opened this issue 1 year ago • 1 comments

Description

I remember running the tests of the polkadot PR at some point and them passing, but now they appear as if they were always broken /facepalm.

Logs: 2024-02-27T21-38-00-cacti-polkadot-connector-test-failures.log

@AnmolBansalDEV Do you remember when the tests broke and what change triggered it?

Acceptance Criteria

  1. Tests are passing

petermetz avatar Mar 11 '24 16:03 petermetz

@petermetz I think when you add new tests to CI they do not run in that particular PR (i.e. CI file is taken from main, not the branch that is being merged), and this suite has been failing from the beginning.

outSH avatar Mar 18 '24 09:03 outSH

@petermetz I think when you add new tests to CI they do not run in that particular PR (i.e. CI file is taken from main, not the branch that is being merged), and this suite has been failing from the beginning.

@outSH Damn. Sorry I missed that and thank you for noticing this hole in our review process.

petermetz avatar May 24 '24 22:05 petermetz