hyperledger
feat(satp-hermes): rules orchestrator layer on SATP
Create a rules orchestrator layer to fine-tune control over the execution of SATP, such that developers can easily create apps on top of SATP.
@petermetz please assign it to me. @AndreAugusto11 and I are managing these tasks.
@AndreAugusto11 @RafaelAPB Please see this change of mine that is pre-emptively (on the main branch) fixing your issue that we talked about this morning: https://github.com/hyperledger/cacti/pull/3047
You can cherry pick it to your branch and then the build should start working (I tested and verified that it does work on your branch when this change is applied).
Thank you for the help @petermetz .Additionally, we will be migrating the issues from my fork to Cacti in the upcoming weeks.
Thank you for the help @petermetz .Additionally, we will be migrating the issues from my fork to Cacti in the upcoming weeks.
@RafaelAPB AWESOME news! Thank you very much for doing that!!!
@AndreAugusto11 @RafaelAPB Please see this change of mine that is pre-emptively (on the main branch) fixing your issue that we talked about this morning: #3047
You can cherry pick it to your branch and then the build should start working (I tested and verified that it does work on your branch when this change is applied).
@petermetz thank you very much for the help!
I shared with you one branch where the error was visible, but that did not have the entire code. After cherry-picking your commit, there seems to be another error, unrelated to our changes, but also unrelated to the fix in #3047.
The new branch: https://github.com/RafaelAPB/blockchain-integration-framework/pull/73
Error: https://github.com/RafaelAPB/blockchain-integration-framework/actions/runs/8116917052/job/22187970415?pr=73#step:5:1046
Do you have any idea?
@AndreAugusto11 @RafaelAPB Please see this change of mine that is pre-emptively (on the main branch) fixing your issue that we talked about this morning: #3047 You can cherry pick it to your branch and then the build should start working (I tested and verified that it does work on your branch when this change is applied).
@petermetz thank you very much for the help!
I shared with you one branch where the error was visible, but that did not have the entire code. After cherry-picking your commit, there seems to be another error, unrelated to our changes, but also unrelated to the fix in #3047.
The new branch: RafaelAPB#73
Error: https://github.com/RafaelAPB/blockchain-integration-framework/actions/runs/8116917052/job/22187970415?pr=73#step:5:1046
Do you have any idea?
@AndreAugusto11 Not sure what it was but after I rebased your branch onto upstream/main (and resolved all the yarn.lock conflicts along the way) then yarn configure works just fine on my machine.
I tried to force push my changes back to your branch but it won't let me:
$ git push --force-with-lease
Enumerating objects: 541, done.
Counting objects: 100% (541/541), done.
Delta compression using up to 16 threads
Compressing objects: 100% (263/263), done.
Writing objects: 100% (459/459), 328.52 KiB | 10.60 MiB/s, done.
Total 459 (delta 218), reused 351 (delta 149), pack-reused 0
remote: Resolving deltas: 100% (218/218), completed with 43 local objects.
remote: This repository moved. Please use the new location:
remote: https://github.com/AndreAugusto11/cacti.git
To https://github.com/andreaugusto11/cacti
! [remote rejected] gateway-coordinator-59-testing -> gateway-coordinator-59-testing (permission denied)
error: failed to push some refs to 'https://github.com/andreaugusto11/cacti'
Could you please invite me as a collaborator to your fork repo and then I'll be able to push the results of the conflict resolution I've done on the yarn.lock file to make it work.
I suspect that the reason why the build is broken is because the dependencies are not in sync with what the lock file has but this is just a theory until we verify that my changes make it work on your machine and the CI as well.
@AndreAugusto11 @RafaelAPB In the meantime (while I get the collaborator invite) you can try out if my fixes work for you as well, I pushed the branch onto my fork for now just so that you can take a peek: https://github.com/petermetz/cacti/tree/gateway-coordinator-59-testing
Hey @petermetz sorry for the delay. I've tested your branch, but it does not work on my machine as well — the same errors are thrown. The collab invite was already sent, if you could push the changes and trigger the CI it would be great (I'm thinking that my setup might have something weird going on)
Hey @petermetz sorry for the delay. I've tested your branch, but it does not work on my machine as well — the same errors are thrown. The collab invite was already sent, if you could push the changes and trigger the CI it would be great (I'm thinking that my setup might have something weird going on)
@AndreAugusto11 No worries, I just force pushed to your branch (now that I have permission) and the build is still working fine on my machine so let's have the CI as a tie breaker. If it fails there then I can look into the errors there but if it doesn't then it's definitely something going wrong with your local setup/local changes that are not on the branch.
A list of things that failed while doing a yarn custom-checks are listed below (which are not important for now but we can't merge the pull request until they are all fixed)
ERROR: packages/cactus-plugin-bungee/src/main/json/openapi.json "info.license.name" must be Apache-2.0
ERROR: packages/cactus-plugin-bungee/package.json the package itself incorrectly has version 1.0.0. Expected 2.0.0-alpha.2
ERROR: Packages packages/cactus-plugin-satp-hermes/package.json is not sorted
"reflect-metadata" is a missing dependency from /home/peter/a/cacti/packages/cactus-plugin-satp-hermes/package.json with the following files using them:
/home/peter/a/cacti/packages/cactus-plugin-satp-hermes/src/main/typescript/gateway-refactor.ts
"yargs" is a missing dependency from /home/peter/a/cacti/packages/cactus-plugin-satp-hermes/package.json with the following files using them:
/home/peter/a/cacti/packages/cactus-plugin-satp-hermes/src/main/typescript/gateway-refactor.ts