hyperledger
ci: custom check for package module,main,types,etc.
Right now there is no automated check to verify that the main, types and module properties in the package.json files of packages of the monorepo are set up as they should be and this can lead to situations where maintainers miss these mistakes and then approve packages that are not actually working in terms of the build of the whole repo.
There should be a check that makes this a non-issue by enforcing it within the CI.
Hey @petermetz, I'd love to create a automated check for this issue and I was wondering if you could tell me more about it. I know that the monorepo is where code for multiple projects are stored in the same repository. Sorry if this is an obvious question but which parts of cactus is the monorepo?
situations where maintainers miss these mistakes and then approve packages
When you mention packages here, do you mean a package such as cactus-plugin-ledger-connector-besu?
maintainers miss these mistakes and then approve packages that are not actually working in terms of the build of the whole repo.
I feel as though that this is already being checked by the CI build themselves? If we are adding packages doesn't the CI build for node-14 and node-16 already see if the approved packages are compatible for the while repo?
This issue will be considered if the depending package remains, as part of the cleanup initiative: https://github.com/hyperledger-cacti/cacti/issues/4037
