besu icon indicating copy to clipboard operation
besu copied to clipboard

[LOGGING] snap pipeline errors and peer reputation

Open gfukushima opened this issue 10 months ago • 4 comments

PR description

  • Log any possible throwables we're getting up on snap requests
  • also changes from #6831 - log peer as part of peer reputation registerX()

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • [ ] Checked out our contribution guidelines?
  • [ ] Considered documentation and added the doc-change-required label to this PR if updates are required.
  • [ ] Considered the changelog and included an update if required.
  • [ ] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • [ ] unit tests: ./gradlew build
  • [ ] acceptance tests: ./gradlew acceptanceTest
  • [ ] integration tests: ./gradlew integrationTest
  • [ ] reference tests: ./gradlew ethereum:referenceTests:referenceTests

gfukushima avatar Apr 10 '24 04:04 gfukushima

maybe we want to throttle this, depending on how spammy it is?

macfarla avatar Apr 12 '24 00:04 macfarla

going to test this on some nodes and see how spammy it is

macfarla avatar Apr 12 '24 00:04 macfarla

combined this with changes from #6831

macfarla avatar Apr 29 '24 05:04 macfarla

going to test this on some nodes and see how spammy it is

too spammy at info level. changed to debug.

macfarla avatar Apr 29 '24 05:04 macfarla