besu
besu copied to clipboard
Feature/fleet mode rebase
PR description
rebase onto main of the services refactor for fleet mode, see original #6003
Fixed Issue(s)
@jframe could you check the block pruning modification we are doing in this PR to be sure it's correct. normally we did tests but I prefer to have your feedback
@jframe could you check the block pruning modification we are doing in this PR to be sure it's correct. normally we did tests but I prefer to have your feedback
I inadvertentlty tested this feature on the captain of a captain-follower sepolia pair, and block pruning is definitely working.
did we tried follower+leader with this last commit ?
I am resyncing the follower now to ensure it works correctly, since it failed to find the pruned captain blocks on the prior test 😂
did we tried follower+leader with this last commit ?
Yes, confirmed the follower syncs and follows with only a leader.
Regarding the pruner on the follower, I see it configured, but I am not seeing any executions of the pruner triggered.
@jframe could you check the block pruning modification we are doing in this PR to be sure it's correct. normally we did tests but I prefer to have your feedback
Is the changes in the ChainDataPruner to only start pruning after the initial sync? Think it's better not to delay this until after the initial sync to keep the storage used small. Ideally, you would have Besu configured with --Xcheckpoint-post-merge-enabled
so there isn't anything to prune anyway. Probably need to think more about how these and sync all interact.