besu icon indicating copy to clipboard operation
besu copied to clipboard

Fix Broken RPC Hive Tests

Open iamhsk opened this issue 2 years ago • 7 comments

Acceptance Criteria

  • Investigate why rpc-compat and rpc test suites have so many failing tests
  • Fix any correctly failing tests

Note

iamhsk avatar Oct 06 '22 18:10 iamhsk

several errors can be explained by besu not implementing methods:

  • debug_getRawBlock
  • debug_getRawHeader
  • debug_getRawReceipts
  • debug_getRawTransaction These are also not implemented by nimbus/nethermind/erigon - only geth

macfarla avatar Oct 06 '22 23:10 macfarla

Also method not found for eth_createAccessList which already has an issue #3400

macfarla avatar Oct 07 '22 00:10 macfarla

https://github.com/hyperledger/besu/issues/4503 Another difference is besu includes publicKey and raw fields in the "transactions" response for eth_getBlockByNumber/Hash

macfarla avatar Oct 07 '22 00:10 macfarla

https://github.com/hyperledger/besu/issues/4504 Another is for eth_getProof besu has key 0x1 and geth has 0x01

macfarla avatar Oct 07 '22 00:10 macfarla

https://github.com/hyperledger/besu/issues/4505 And for eth_getTransactionReceipt geth has an extra field type

macfarla avatar Oct 07 '22 00:10 macfarla

This one is interesting - tx not processed because of gas price

	>>  {"jsonrpc":"2.0","id":27,"method":"eth_sendRawTransaction","params":["0xf86303018261a894aa000000000000000000000000000000000000000a825544820a95a0487f7382a47399a74c487b52fd4c5ff6e981d9b219ca1e8fcb086f1e0733ab92a063203b182cd7e7f45213f46e429e1f5ab2a5660a4ed54b9d6ee76be8d84d5ca8"]}
<<  {
  "jsonrpc" : "2.0",
  "id" : 27,
  "error" : {
    "code" : -32009,
    "message" : "Gas price below configured minimum gas price"
  }
}
response differs from expected:
 {
-  "error": {
-    "code": -32009,
-    "message": "Gas price below configured minimum gas price"
-  },
   "id": 27,
   "jsonrpc": "2.0"
+  "result": "0xd02709b29dba8e71897d1d28d57712b69221d3d6e5e0b50fd05aa097a567f30f"
 }

macfarla avatar Oct 07 '22 00:10 macfarla

those under rpc seem to all fail with the error could not fund account eg https://hivetests2.ethdevops.io/?page=v-pills-results-tab&suite=1665365843-7723b6f8498880db60b6c679527e30b2.json

macfarla avatar Oct 10 '22 04:10 macfarla

Closing after generating specific GH issues.

iamhsk avatar Oct 26 '22 23:10 iamhsk