besu icon indicating copy to clipboard operation
besu copied to clipboard

Nonce of private transaction not incrementing when private transaction reverts

Open MadelineMurray opened this issue 4 years ago • 6 comments

Raised in RocketChat:

Hi community, We have noticed that if a private tx reverts (e.g, when a require condition fails), then the private nonce is not incremented. On the other hand, the public nonce, that of the privacy marker tx, do increment. So my question is: ¿is there any way to change this behaviour, allowing the private nonce to increment? We have found this situation problematic when leading with concurrent private tx, because if tx n fails, then n+1, n+2, etc will also fail. Thank you very much in advance community!

  • [x] Confirm behaviour is inconsistent with public transaction behaviour
  • [ ] Document current behaviour as a known issue
  • [ ] (longer term) If yes, fix. Fix will require a CLI option or preferably something better (something in the database possibly) to not break backwards compatibility. -> this might be support for forks in privacy - and this is also a way to deprecate privacy methods in future

MadelineMurray avatar Feb 24 '21 03:02 MadelineMurray

@pinges what is this blocked by? or does it just need to be re-prioritised?

vmichalik avatar May 25 '21 07:05 vmichalik

Need to determine if this would break existing users' workflows

vmichalik avatar May 27 '21 07:05 vmichalik

Hi, @vmichalik @pinges Can you tell me if this behavior is intended or not? If this is a bug, can you tell me if there are any plans to fix it or how to workaround it?

sirano11 avatar Jul 05 '22 06:07 sirano11

@macfarla - stale? can i close?

non-fungible-nelson avatar Jan 26 '23 10:01 non-fungible-nelson

@antonydenyer any update on your draft PR?

macfarla avatar Jan 30 '23 05:01 macfarla

Yes, still in progress. Couple things to consider around 'transitions/forks' with existing networks.

antonydenyer avatar Jan 30 '23 17:01 antonydenyer