aries-vcx icon indicating copy to clipboard operation
aries-vcx copied to clipboard

Use `Did` type in `messages` crate

Open Patrik-Stas opened this issue 1 year ago • 1 comments
trafficstars

  • messages https://github.com/hyperledger/aries-vcx/tree/main/aries/messages crate typically types DID attributes (for example in did-exchange ResponseContent message type) as String.
  • Use did_parser_nom's https://github.com/hyperledger/aries-vcx/tree/main/did_core/did_parser_nom Did type instead so we parse&verify DIDs upon message deserialization.

Patrik-Stas avatar Mar 23 '24 03:03 Patrik-Stas

Hello @Patrik-Stas I have created a PR #1171 for this.

Apart from the instances resolved in the PR, there are multiple other instances in agent, misc, etc where did is typed as a string.

Do I convert the PR to draft and add those instances as well?

GHkrishna avatar Mar 31 '24 10:03 GHkrishna