aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard

`--base-wallet-routes` flag no longer works

Open dbluhm opened this issue 1 year ago • 3 comments

After the swap to using decorators to delineate routes accessible by tenants and routes accessible by admins, the ability to grant access to the base wallet to additional routes was lost.

This option made it possible for a base wallet to form a didcomm connection with a mediator and then use that as a base mediator for all tenants, among other things.

cc @esune @jamshale

dbluhm avatar Oct 11 '24 17:10 dbluhm

So many configs... Guess the flag wasn't tested. I'll wait and see if Emiliano knows an easy way to fix it.

jamshale avatar Oct 11 '24 17:10 jamshale

Yeah, indeed, I only just detected this myself.

dbluhm avatar Oct 11 '24 17:10 dbluhm

I didn't even know this setting/option existed 😅. My understanding was that the base wallet would always ONLY deal with tenant provisioning tasks and nothing else, so the decorators were set-up to function this way.

That being said, I think we would have to move this logic into the tenant_authentication decorator for things to work.

Adding a separate decorator just for this would be also an option and it would be more explicit, however the fact that we'd have to basically blanket apply it everywhere AND, more importantly, the added complexity of having multiple decorators stacked (in the right order) makes me think it is actually not the best option.

esune avatar Oct 11 '24 17:10 esune

Taking a stab at this since it was brought up at today's maintainers meeting

esune avatar Nov 19 '24 18:11 esune