aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard

Newly created wallet is assumed to be from older version and upgraded

Open rngadam opened this issue 1 year ago • 1 comments

1.0.0-19-gb85bb14f1

New agent start with in-memory storage creates a basic wallet:

 scripts/run_docker start --no-ledger --no-transport --log-level info
2024-08-20 14:29:18,395 aries_cloudagent.core.profile INFO Create profile manager: in_memory
2024-08-20 14:29:18,401 aries_cloudagent.config.ledger INFO Ledger instance not provided
2024-08-20 14:29:18,401 aries_cloudagent.core.conductor WARNING No ledger configured
2024-08-20 14:29:18,421 aries_cloudagent.core.conductor WARNING Wallet type record not found.
2024-08-20 14:29:18,421 aries_cloudagent.core.conductor INFO New agent. Setting wallet type to basic.

Even though the wallet was just created, it goes through the upgrade process anyway:

2024-08-20 14:29:18,422 aries_cloudagent.core.conductor WARNING Wallet version storage record not found.
2024-08-20 14:29:18,422 aries_cloudagent.core.conductor WARNING No upgrade from version was found from wallet or via --from-version startup argument. Defaulting to v0.7.5.
2024-08-20 14:29:18,425 aries_cloudagent.commands.upgrade INFO No ACA-Py version found in wallet storage.
2024-08-20 14:29:18,425 aries_cloudagent.commands.upgrade INFO Selecting v0.7.5 as --from-version from the config.
2024-08-20 14:29:18,425 aries_cloudagent.commands.upgrade INFO Running upgrade process for v0.8.1
2024-08-20 14:29:18,425 aries_cloudagent.commands.upgrade INFO No records of <class 'aries_cloudagent.connections.models.conn_record.ConnRecord'> found
2024-08-20 14:29:18,426 aries_cloudagent.commands.upgrade INFO acapy_version storage record set to v1.0.0

rngadam avatar Aug 20 '24 15:08 rngadam

I don't think this actually upgrades anything for an empty wallet, but perhaps the logging could be more clear or the logic could be handled a bit better.

jamshale avatar Aug 20 '24 16:08 jamshale