aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard

Published 20 hours ago • verified publisher icon hyperledger

:arrow_up: Upgrade pydid (pydantic v2)

Open ff137 opened this issue 9 months ago • 1 comments

Testing pydid upgrade to pydantic v2: https://github.com/Indicio-tech/pydid/pull/72

Edit: Great! All checks have passed. Marking as draft until pydid update is released

ff137 avatar Apr 26 '24 11:04 ff137

@ff137 I think this should be ready for review now; would you be able to regenerate the lock file?

dbluhm avatar May 14 '24 18:05 dbluhm

@dbluhm Nice! I missed that 0.5.0 was released. I'll rebase 👍

One thing to keep in mind is that the acapy-plugins will need to also be upgrade to pydantic v2, to ensure compatibility.

ff137 avatar May 14 '24 19:05 ff137

@jamshale @amanji heads up on @ff137's point. Do you anticipate any challenges with the plugins you maintain?

I think there would be a conflict with the pickup plugin we maintain. We haven't done major updates to that plugin in a while though so maybe it's just time to retire it.

dbluhm avatar May 15 '24 02:05 dbluhm

I don't think it would affect DRPC

amanji avatar May 15 '24 02:05 amanji

FWIW the redis-events plugin uses pydantic v1, and we did an upgrade for that when testing this release. So I can contribute pydantic V2 for that one plugin. Can help with the others too, because I've memorised a lot of the migration steps :-)

ff137 avatar May 15 '24 06:05 ff137

Yes. I think some plugins will need to be updated. I know the oid4vci plugin has a pydantic dependency.

We have the release management system merged for the plugin repo just now, so the upgrades could be prepared and then merged after the aca-py release.

jamshale avatar May 15 '24 16:05 jamshale

This is why the release management should help. If we don't update a plugin and retire it. It is now tagged with 0.12.1 (All plugins are currently passing). It can just be left behind unless we chose to upgrade it. No need to remove it or anything.

jamshale avatar May 15 '24 16:05 jamshale

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 15 '24 17:05 sonarqubecloud[bot]

@dbluhm I'm eager to get this one merged 😄 because there's a rebase-and-wait-for-tests loop to go through for #2939 and #2940 as well. Maybe I can merge those 2 into 1 PR, if it's alright with you

ff137 avatar May 15 '24 18:05 ff137