aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard

feat: drop indy sdk

Open dbluhm opened this issue 1 year ago • 2 comments

Resolves #2865

This PR removes all components and tests referencing the Indy SDK library. This was accomplished by working through each module depending on the library, removing it, and then adjusting the places that referenced that module to be updated to point to replacing components.

It should be noted that the code base was already in a pretty good state; the Indy SDK dependencies were pretty neatly isolated. The "worst" of these updates was the odd test here and there that was directly using Indy SDK pieces when they should have been using things like InMemoryProfile.test_profile() or similar.

We have already ceased running tests for Indy specific components automatically in GHA. Because of this, I'm confident the removal of Indy specific tests should not cause a gap we've not already filled. However, I think this will technically result in less overall code coverage of the tests, if you were considering both the indy and non-indy tests.

dbluhm avatar Apr 13 '24 19:04 dbluhm

~~I'm not sure about my changes in aries_cloudagent/ledger/multiple_ledger/manager_provider.py~~ I think I figured it out.

dbluhm avatar Apr 13 '24 19:04 dbluhm

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 24 '24 17:04 sonarqubecloud[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 20 '24 16:05 sonarqubecloud[bot]

@jamshale @ianco merged in main and resolved conflicts in the poetry lock. This will need a fresh review but then should be ready to merge. Thanks!

dbluhm avatar May 20 '24 16:05 dbluhm