aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard

0.7.5 Cherry Picks

Open TheTechmage opened this issue 2 years ago • 3 comments

These are the cherry picks for Milestone 0.7.5 https://github.com/hyperledger/aries-cloudagent-python/milestone/6

  • [X] https://github.com/hyperledger/aries-cloudagent-python/pull/1881 (Already Merged into https://github.com/hyperledger/aries-cloudagent-python/tree/hotfix/0.7.5)
  • [x] https://github.com/hyperledger/aries-cloudagent-python/pull/1940
  • [X] https://github.com/hyperledger/aries-cloudagent-python/pull/1960
  • [ ] https://github.com/hyperledger/aries-cloudagent-python/pull/1962

TheTechmage avatar Oct 06 '22 19:10 TheTechmage

Both https://github.com/hyperledger/aries-cloudagent-python/pull/1940 and https://github.com/hyperledger/aries-cloudagent-python/pull/1962 appear to have merge conflicts in one form or another. The commits from https://github.com/hyperledger/aries-cloudagent-python/pull/1940 made assumptions about work that had been made within other commits (most notably, within the tests).

I moved on to merging https://github.com/hyperledger/aries-cloudagent-python/pull/1962, but this appears to have been a mistake. I will switch back to merging https://github.com/hyperledger/aries-cloudagent-python/pull/1940 and resolving any merge conflicts before proceeding on with https://github.com/hyperledger/aries-cloudagent-python/pull/1962.

TheTechmage avatar Oct 06 '22 19:10 TheTechmage

Force-push due to a commit missing a valid GPG signature

TheTechmage avatar Oct 07 '22 14:10 TheTechmage

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Oct 10 '22 21:10 sonarqubecloud[bot]

Codecov Report

:exclamation: No coverage uploaded for pull request base (hotfix/0.7.5@e84fc18). Click here to learn what that means. The diff coverage is n/a.

@@               Coverage Diff               @@
##             hotfix/0.7.5    #1967   +/-   ##
===============================================
  Coverage                ?   93.59%           
===============================================
  Files                   ?      537           
  Lines                   ?    34266           
  Branches                ?        0           
===============================================
  Hits                    ?    32070           
  Misses                  ?     2196           
  Partials                ?        0           

codecov-commenter avatar Oct 10 '22 21:10 codecov-commenter

@frostyfrog -- we need to cherry pick another PR: #1973 -- a one liner. Could you please do that? It is updating a dependency for web.py from a git reference to a released version.

@frostyfrog @dbluhm @WadeBarnes -- opinion needed: Assuming this cherry pick goes well, do you think I should do an 0.7.5-rc1 release or would it be safe enough to go straight to 0.7.5 final after local pre-release testing?

swcurran avatar Oct 18 '22 16:10 swcurran

I'd go with an 0.7.5-rc1.

WadeBarnes avatar Oct 18 '22 17:10 WadeBarnes