aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard

Discrepancy between service object and service decorator

Open rmnre opened this issue 3 years ago • 1 comments

The service object which is used to advertise a service endpoint in an OOB invitation aligns with RFC 0067 and the DID spec. The service decorator which was added in #1710 does not; it lacks the mandatory params id and type. I reckon this is because it was created according to RFC 0056: Service Decorator which references an older version of the DID spec? I believe it would make sense to use the same (spec-compliant) model for both.

rmnre avatar Sep 20 '22 14:09 rmnre

@TimoGlastra -- can you please take a look at this one. #1710 was a PR that you added, so you probably have the best context for this. @andrewwhitehead -- you might take a look as well.

Thanks

swcurran avatar Sep 20 '22 16:09 swcurran