Codecov Report

Merging #1938 (d850309) into main (960aa91) will decrease coverage by 0.07%. The diff coverage is 54.25%.

@@            Coverage Diff             @@
##             main    #1938      +/-   ##
==========================================
- Coverage   93.60%   93.52%   -0.08%     
==========================================
  Files         539      539              
  Lines       34456    34527      +71     
==========================================
+ Hits        32251    32290      +39     
- Misses       2205     2237      +32

Sep 12 '22 06:09 codecov-commenter

LGTM, maybe another unit test to improve the code coverage wouldn't hurt.

Sep 12 '22 06:09 andrewwhitehead

LGTM, maybe another unit test to improve the code coverage wouldn't hurt.

Thanks! Yes testing is on my list before I mark the pr as ready for review

Sep 12 '22 15:09 ianco

@andrewwhitehead @shaangill025 @swcurran possible to get this PR reviewed?

Oct 12 '22 15:10 ianco

I think we can revert changes made to conductor in PR#1970 due to the changes made to oob_record in this PR.

Oct 13 '22 15:10 shaangill025

Looks like the web-py change did not fix the problem. Can we please get a separate PR that fixes just the web-py issue? I'll enter an issue. It is breaking all integration test runs.

Oct 13 '22 23:10 swcurran

@swcurran can we get this PR reviewed/merged? Right now I'm building some of the endorser deploys off my branch because they rely on this functionality, thx!

Oct 17 '22 16:10 ianco

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Oct 17 '22 16:10 sonarqubecloud[bot]

Endorser write DID transaction

Codecov Report