aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard

did:orb not accepted when creating json-ld credentials

Open ianco opened this issue 3 years ago • 3 comments

In AATH, try running: ./manage run -d acapy-main -t @DidMethod_orb

All the tests fail with the following error:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/webargs/asyncparser.py", line 90, in parse
    result = schema.load(parsed)
  File "/usr/local/lib/python3.7/site-packages/marshmallow/schema.py", line 723, in load
    data, many=many, partial=partial, unknown=unknown, postprocess=True
  File "/usr/local/lib/python3.7/site-packages/marshmallow/schema.py", line 904, in _do_load
    raise exc
marshmallow.exceptions.ValidationError: {'method': ['Must be one of: key, sov.']}

@dbluhm ?

ianco avatar Aug 15 '22 15:08 ianco

Marshmallow shouldn't be rejecting other than did:key and did:sov. This may be related to the W3C VC work, I suspect. I think this had worked previously, but seems to have been changed at some point. AFAIK, the did:orb tests were working when last worked on.

swcurran avatar Aug 15 '22 16:08 swcurran

Perhaps here?

swcurran avatar Aug 15 '22 16:08 swcurran

Is this test trying to register or resolve a did:orb DID? If it is trying to resolve it, this should work. If it is trying to register it, this should not work. Given that the test is ALL ACA-Py, my guess is that this one trying to register a DID, and therefore, we can safely make the change that @ianco has proposed in AATH of disabling the did:orb tests for ACA-Py only runs.

swcurran avatar Aug 19 '22 15:08 swcurran