python-3.10 update

[burdettadam]

UNDER RAPID DEVELOPMENT!

This draft PR updates ACA-PY to use python-3.7 along with dependency updates. For questions during development please reach out to @burdettadam or @dbluhm.

[dbluhm]

Anyone feel like making a von-image on python 3.7 for us? :slightly_smiling_face:

[swcurran]

@WadeBarnes -- we can talk about this. I think the easiest way to do it would be to have a 0.9.0-rc1 tag (or perhaps 0.9.0-exp1 for "experimental") after we merge the PR. We would then use a 3.7 base in building the image and then testing it.

@dbluhm -- do you want/need this before the merge of the PR? I'm sure that would be possible -- just not the easy way outlined above. A bit more thinking and work.

[swcurran]

We also have to think about how this will impact the daily AATH testing. Presumably the "dockerfile-main" file will have to change when we merge this PR. We can do something locally or on a PR branch for testing this, but for the daily runs, we have to wait until this PR is merged.

[dbluhm]

Yeah, good points; my reason for asking isn't quite so forward thinking -- just trying to get an image base to point circleci and the integration tests to :sweat_smile:

That being said, rather than merging to main, it does seem like perhaps a good idea to have a python 3.7 feature branch that lives in parallel as we sort out updates and fixing deprecation warnings and/or producing experimental builds.

[swcurran]

I'm not an expert on that approach, but do think it sounds like a reasonable idea. I would not want it to live long, but perhaps it should be around for a bit. We do need to get the world used to using 3.7.

[dbluhm]

For now, I've pointed circleci and integration tests to ghcr.io/indicio-tech/von-image:py37-1.16-0 but happy to replace this with a more official image when we're ready.

[codecov-commenter]

Codecov Report

Merging #1854 (1b3617f) into main (f0b2719) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1854   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files         536      536           
  Lines       34015    34013    -2     
=======================================
- Hits        31881    31880    -1     
+ Misses       2134     2133    -1     

[dbluhm]

Using a very rough tool I cobbled together, my most recent commits on this PR update usage of marshmallow fields to correct deprecations made in newer versions. The tool can be found here: https://github.com/dbluhm/acapy-marshmallow-upgrade. This significantly increases the number of lines touched by this PR. I can replay the changes on a different PR if that is preferred.

[sonarcloud[bot]]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
23 Security Hotspots
18 Code Smells

No Coverage information
10.6% Duplication

[swcurran]

What is the status of this @burdettadam / @dbluhm ?

We have a new-to-ACA-Py dev @Jsyro looking at the failing Python 3.7 and 3.10 tests to see if he can get them to run. Should he take over this? Any suggestions on next steps?

Thanks!

[dbluhm]

This PR sought to update dependencies and to resolve deprecation warnings. We solved a number of issues but this PR has since grown stale (partially out of a shift in focus to get container images with newer python versions first, partially out of just getting busy with other tasks). I think this probably just needs to be closed but if we're interested in solving the many deprecation warnings from marshmallow, the pattern I used and described in my comments above I think are still relevant.

[swcurran]

@Jsyro — definitely take a look at the changes and discussion on this.