aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard

Fix tails_local_path format

Open DaevMithran opened this issue 3 years ago • 3 comments

Signed-off-by: DaevMithran [email protected]

Issue is not fixed yet. Tried replacing the white spaces with %20 in tails_local_path. I'm not receiving error in swagger now. I'm receiving error in the logs. And it creates only one rev_reg instead of two now. Can anyone guide me on this?

DaevMithran avatar Jan 11 '22 21:01 DaevMithran

You don't want to use %20 in the path everywhere, only when the tails file is actually pushed to the tails server (with put_file I believe). In this case it would be best to urlencode the parameter rather than replacing spaces specifically.

andrewwhitehead avatar Jan 12 '22 01:01 andrewwhitehead

You don't want to use %20 in the path everywhere, only when the tails file is actually pushed to the tails server (with put_file I believe). In this case it would be best to urlencode the parameter rather than replacing spaces specifically.

Even this did not work. I believe the issue is in indy-tails-server. changing this https://github.com/bcgov/indy-tails-server/blob/main/tails_server/web.py#L135 from os.path.join(storage_path, revocation_reg_id) to os.path.join(storage_path, revocation_reg_id).replace(" ", "\") might work

DaevMithran avatar Jan 13 '22 20:01 DaevMithran

Given that it appears the error is in indy-tails-server, should we close this PR and related issues?

swcurran avatar Mar 16 '22 18:03 swcurran

Closing this PR.

swcurran avatar Sep 02 '22 20:09 swcurran