nephos
nephos copied to clipboard
Refactor helpers code and test into smaller and self-contained files
This pertains to the helpers/misc.py and helpers/k8s.py files.
The first could separate the code for execution of commands (especially if we eventually move the Helm functionality to use an outside library as discussed in #44 or another alternative)
The second is 300 lines long and could be broken down into things that manage K8S secrets and configuration vs. the rest, for example. Similarly, the Executer might be moved into a separate file as well.
Hi, can I take this up?
This pertains to the
helpers/misc.pyandhelpers/k8s.pyfiles.The first could separate the code for execution of commands (especially if we eventually move the Helm functionality to use an outside library as discussed in #44 or another alternative)
The second is 300 lines long and could be broken down into things that manage K8S secrets and configuration vs. the rest, for example. Similarly, the Executer might be moved into a separate file as well.
Hey, wanted to clarify a few things.
Do you want to seperate all the functions from the misc.py file?
Also I'm unable to find documentation for a few comments in k8s.py eg. Ingress on line #124