go-perun
go-perun copied to clipboard
🌔 Perun's Blockchain-Agnostic State Channels Framework in Go.
The `Accept` and `Reject` functions of `ProposalResponder` and `UpdateResponder` can only be called once and panic on a second call. I think this logic should only apply in the success...
### Location `[wire] Localbus.SubscribeClient` the `close(recv.exists)` statement. ### Problem Code panics when it is called twice with the same address. AFAIK the local bus was only intended for testing and...
### Location channel/test ### Problem There do not exist generic tests for the following interfaces: channel.Adjudicator, channel.Funder, channel.AdjudicatorSubscription. The generic backend test does not cover method `DecodeAsset`. ### Proposal We...
### Location `channel/params.go` ### Problem `Params.id` is derived from the other properties of Params and is used to identify an object instance. However, since most properties of Params are exported,...
Related to https://github.com/hyperledger-labs/go-perun/pull/83#discussion_r666230937_ **Problem:** Closing a channel involves calling `channel.Settle` and `channel.Close`. It is easy to mix up the two, or forget to call one of them, and I don't...
Having `err = cherrors.CheckIsChainNotReachableError(err)` in so many places is not nice. It bloats the code size. Could we do something like `defer func(){err = cherrors.CheckIsChainNotReachableError(err)}()`? Even cleaner would be to...
**Context:** Package channel and wallet have an interface type `Backend` that provides a set of utility functions. **Problem:** The name `Backend` suggests that the type provides all kinds of backend...
**Situation**: The `Sig` type in the `[wallet]` package is an alias to `[]byte`. We have `DecodeSig(io.Reader) Sig` and `VerifySig(msg, Sig, addr)` functions. **Problem**: While implementing the `wallet` interface for `sr25519`,...
`NewRandomLedgerChannelProposal` and `NewRandomSubChannelProposal` do the same thing. I don't know why. Just was doing the same. _Originally posted by @matthiasgeihs in https://github.com/hyperledger-labs/go-perun/pull/123#discussion_r662396964_
The design of the persistence is not ideal for SubC and VCs. Maybe it would be good to rethink the design before doing VCs in VCs. _Originally posted by @matthiasgeihs...