go-perun

go-perun copied to clipboard

Add an abstract type for wallet.Sig

2

### Location [wallet] ### Problem Currently `wallet.Sig` is defined as a variable size byte array in the abstract `wallet` package. However, the length of the signature depends upon the signature...

manoranjith

Unclear specification of adjudication methods

1

### Location package `client` package `channel` ### Problem At the moment it is not clearly specified whether the adjudicator methods should wait for the correct phase before on-chain calls are...

matthiasgeihs

### Location client ### Problem The `Adjudicator.Withdraw` functionality waits for a dispute to be over before it concludes the channel state. This is tested for no-app channels. However, if a...

matthiasgeihs

### Location package channel ### Problem When accessing the state of a channel, one must be careful not to do this while another channel operation (e.g., an update) is happening...

matthiasgeihs

### Location Probably `client/failing_funding_test.go`. See CI output for more information: https://github.com/hyperledger-labs/go-perun/runs/7039931517?check_suite_focus=true ### Problem In rare cases, the watcher reports: `ERRO[0005] Error registering dispute: invalid version: expected >=1, got 0`. The...

matthiasgeihs

Settling after finalization through ForceUpdate

2

### Location client/adjudicate.go ### Problem When a client is enforcing an update via `ForceUpdate` (e.g., finalizing the channel) and tries to settle directly after, there is no guarantee that the...

leandro-ro

The stdlib [`gob`](https://pkg.go.dev/encoding/gob) package can be used to encode Go objects over the wire. While trying to use it for encoding some core types, like `channel.State` or `channel.Params`, it didn't...

sebastianst

Synchronisation problem in alice/bob happy test

1

### Location Alice/Bob happy test ### Problem Sometimes, the test fails when the first update is made, because the receiving side thinks that the channel does not yet exist, even...

RmbRT

Yes, because when validating a state we use it to compare `Data` ([here](https://github.com/boschresearch/go-perun/blob/eca5f7032ad79411c06b86d8a5af9144bb954cd9/channel/state.go#L143)). However, in a separate PR, we could implement `Data.Equal` and then remove this function. _Originally posted by...

matthiasgeihs

Move VerifySignature from wallet.Backend to wallet.Sig

1

### Location wallet, ethereum/wallet, sim/wallet ### Problem Previously, VerifySignature function is defined on the wallet backend. This looked fine, because until recently, wallet.Sig was defined as a byte array. But,...

manoranjith