fablo icon indicating copy to clipboard operation
fablo copied to clipboard

depricate test-03-private-data test

Open Sanket-0510 opened this issue 1 year ago • 5 comments

fixes #396 I have removed the test-03-private-data from the CI and have also renamed couple of files in CI as well as in script.

  • [x] Remove test-03-private-data check - both from CI and the whole test script
  • [x] Move private data checks to test-02-private-data
  • [x] Rename remaining checks, to keep naming consistent (i.e. either rename 04 to 03, or remove numbers entirely from names)
  • [x] Update TEST_CASES.md to reflect the updated test cases

Sanket-0510 avatar May 21 '24 15:05 Sanket-0510

@dzikowski @Hejwo one doubt I have is that do we still need private-data checks in the CI but under some other job?

Sanket-0510 avatar May 21 '24 15:05 Sanket-0510

Yes, preferrably in test-02

dzikowski avatar May 21 '24 16:05 dzikowski

Yes, preferrably in test-02

got it, onto it

Sanket-0510 avatar May 21 '24 16:05 Sanket-0510

Yes, preferrably in test-02

you mean in test-02-Raft job? isn't that specially for raft?

Sanket-0510 avatar May 21 '24 16:05 Sanket-0510

yes, the raft one. Those tests are too heavy to have a separated one for private data, so I think it is fine to combine it with raft. Also have a look at the checklist here: https://github.com/hyperledger-labs/fablo/issues/396

dzikowski avatar May 21 '24 16:05 dzikowski

resolved in https://github.com/hyperledger-labs/fablo/pull/467

dzikowski avatar Aug 08 '24 09:08 dzikowski